Re: [PATCH 04/47] staging/lustre/gss: Shared key mechanism & flavors

From: Greg Kroah-Hartman
Date: Sun Apr 27 2014 - 13:19:57 EST


On Sun, Apr 27, 2014 at 01:06:28PM -0400, Oleg Drokin wrote:
> From: Andrew Korty <ajk@xxxxxx>
>
> Implement security flavors and GSSAPI mechanism to perform shared key
> authentication (ski) and encryption (skpi).
>
> Signed-off-by: Andrew Korty <ajk@xxxxxx>
> Reviewed-on: http://review.whamcloud.com/8629
> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3289
> Reviewed-by: Andreas Dilger <andreas.dilger@xxxxxxxxx>
> Reviewed-by: Ken Hornstein <kenh@xxxxxxxxxxxxxxxx>
> Signed-off-by: Oleg Drokin <oleg.drokin@xxxxxxxxx>

Why are you adding new features to the code?

I really want the code cleaned up properly first, before anything new
can be added to it. Otherwise it's just a loosing battle of cleanups
needed for the stuff you keep adding.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/