Re: [PATCH 3.13] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

From: Josh Boyer
Date: Wed Apr 23 2014 - 09:31:39 EST


On Tue, Apr 22, 2014 at 3:18 PM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
> From: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
>
> commit 36d5fe6a000790f56039afe26834265db0a3ad4c upstream.
>
> skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
> orphan them. Also, it doesn't handle errors, so this patch takes care of that
> as well, and modify the callers accordingly. skb_tx_error() is also added to
> the callers so they will signal the failed delivery towards the creator of the
> skb.
>
> Signed-off-by: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> [bwh: Backported to 3.13: skb_zerocopy() is new in 3.14, but was moved from a
> static function in nfnetlink_queue. We need to patch that and its caller, but
> not openvswitch.]
> Signed-off-by: Ben Hutchings <ben@xxxxxxxxxxxxxxx>

Deja-vu. I sent almost the same patch to netdev a while ago and you
acked it there. So I guess I'll ack your copy as well :). Not sure
why either version wasn't picked up by Dave.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/