Re: [RFC PATCH] video: Use fb_sys_write rather than open-coding in drivers

From: Tomi Valkeinen
Date: Tue Feb 11 2014 - 09:06:30 EST


On 20/09/13 10:06, Ryan Mallon wrote:
> Several video drivers open code the fb_write write function with code
> which is very similar to fb_sys_write. Replace the open code versions
> with calls to fb_sys_write. An fb_sync callback is added to each of
> the drivers.
>
> Signed-off-by: Ryan Mallon <rmallon@xxxxxxxxx>
> ---

Doesn't this change the behavior so that fb_write does no longer update
the display, but fb_sync does? I don't think fb_sync is even meant to
update the display, it's meant to wait for an update to finish. Then
again, I'm not sure about that, all I see in fb.h is "wait for blit
idle, optional"

Tomi


Attachment: signature.asc
Description: OpenPGP digital signature