Re: [PATCH 11/11] ext4: add cross rename support

From: J. Bruce Fields
Date: Thu Jan 16 2014 - 09:49:09 EST

On Thu, Jan 16, 2014 at 11:54:06AM +0100, Miklos Szeredi wrote:
> > On Wed, Jan 15, 2014 at 7:23 PM, J. Bruce Fields <bfields@xxxxxxxxxxxx> wrote:
> > > Do you have a man page update somewhere for the two new flags?
> Here's the updated man page (and attached the patch)

Looks good to me. Total nits:

> Don't overwrite the target of the rename. Return an error if
> the target would be overwritten.

s/Return an error/Fail with EEXIST/?

(Since it doesn't literally return the error.)

> ENOENT flags contain RENAME_EXCHANGE and the target of the rename does
> not exist

s/the target of the rename/either of the two files/

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at