Re: [PATCH 03/14] sched: SCHED_DEADLINE structures &implementation.

From: Steven Rostedt
Date: Wed Nov 20 2013 - 15:24:14 EST


On Thu, 7 Nov 2013 14:43:37 +0100
Juri Lelli <juri.lelli@xxxxxxxxx> wrote:


> +/*
> + * This function validates the new parameters of a -deadline task.
> + * We ask for the deadline not being zero, and greater or equal
> + * than the runtime.
> + */
> +static bool
> +__checkparam_dl(const struct sched_param2 *prm)
> +{
> + return prm && (&prm->sched_deadline) != 0 &&
> + (s64)(&prm->sched_deadline - &prm->sched_runtime) >= 0;

Patch 6 brought this to my attention. Looks like using the address of
the fields is wrong. I know patch 6 fixes this, but lets make it
correct in this patch first.

Thanks,

-- Steve


> +}
> +
> +/*
> * check the target process has a UID that matches the current process's
> */
> static bool check_same_owner(struct task_struct *p)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/