Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check fornull

From: Ben Myers
Date: Thu Oct 31 2013 - 11:56:11 EST


On Fri, Oct 25, 2013 at 10:06:09AM -0500, Ben Myers wrote:
> On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote:
> > ASSERT on args takes place after args dereference.
> > This assertion is redundant since we are going to panic anyway.
> >
> > Found by Linux Driver Verification project (linuxtesting.org) -
> > PVS-Studio analyzer.
> >
> > Signed-off-by: Denis Efremov <yefremov.denis@xxxxxxxxx>
>
> Looks good.
>
> Reviewed-by: Ben Myers <bpm@xxxxxxx>

Applied. Thanks Denis.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/