Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check fornull

From: Ben Myers
Date: Fri Oct 25 2013 - 11:06:19 EST

On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote:
> ASSERT on args takes place after args dereference.
> This assertion is redundant since we are going to panic anyway.
> Found by Linux Driver Verification project ( -
> PVS-Studio analyzer.
> Signed-off-by: Denis Efremov <yefremov.denis@xxxxxxxxx>

Looks good.

Reviewed-by: Ben Myers <bpm@xxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at