Re: [PATCH -tip 1/2] [BUGFIX] kprobes/x86: Prohibit probing ondebug_stack_*
From: Ingo Molnar
Date: Thu Oct 31 2013 - 04:22:42 EST
* Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:
> -int is_debug_stack(unsigned long addr)
> +int __kprobes is_debug_stack(unsigned long addr)
_Please_ add a __noprobes method, for new annotations.
Naming it '__kprobes' is actively confusing, as it suggests that the
function is somehow positively involved with kprobes support.
Instead it should the noinline/notrace pattern.
I complained about this before and not much happened on this front.
We might not want to convert the whole kernel straight away, but for
_new_ annotations there's no excuse not to name them properly. Lets
phase out __kprobes, and use __noprobe from now on, okay?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/