Re: [GIT PULL] locking fix
From: Ingo Molnar
Date: Mon Oct 28 2013 - 04:47:16 EST
* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Sun, Oct 27, 2013 at 12:56 PM, Maarten Lankhorst
> <maarten.lankhorst@xxxxxxxxxxxxx> wrote:
> > And this is why ww_ctx == NULL is now passed as an inline
> > argument. :)
> Well, more than that - the "optimization" has been done at the
> source code level, so that the behavior is no longer a matter
> about how well the compiler optimizes it any more.
> I'm not complaining about the fix. I'm complaining about how the
> fix was claimed to be due to a compiler bug. The "documentation"
> for the fix (ie the commit message) was actively misleading.
Agreed, there was quite a bit of back and forth and I genuinely got
confused and thought it's purely about a compiler bug (hence the
misleading pull request) - will watch out for that pattern better
next time around.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/