Re: [GIT PULLv2] For x86/mce ... enhanced error logs

From: Matt Fleming
Date: Sun Oct 27 2013 - 16:22:23 EST


On Sun, 27 Oct, at 12:01:48PM, Borislav Petkov wrote:
> On Sun, Oct 27, 2013 at 08:00:35AM +0100, Ingo Molnar wrote:
> >
> > * Tony Luck <tony.luck@xxxxxxxxx> wrote:
> >
> > > > Hm, I'm not sure we should move something named after a hardware
> > > > feature into lib/. It's not really generic C library functionality,
> > >
> > >
> > > Not a hardware feature. CPER stands for Common Platform Error Record
> > > from the UEFI standard. [...]
> >
> > By all means UEFI can be considered platform dependent at the moment:
> >
> > comet:~/tip> git grep -i uefi arch/arm/
> > comet:~/tip> git grep -i uefi arch/arm64/
> > comet:~/tip> git grep -i uefi arch/powerpc/
> > comet:~/tip> git grep -i uefi arch/mips/
> > comet:~/tip>
> >
> > If a committee says that a name of some standard is 'common platform' does
> > not make it so. lib/ is mostly kept for mathematical, C-library alike
> > functionality you see in CS textbooks.
> >
> > > As Chen Gong points out, drivers/acpi isn't the right place ... so if
> > > not lib/ ... then where?
> >
> > drivers/uefi/?
>
> Hmm, we do have drivers/firmware/, even drivers/firmware/efi/ subdir and
> since this thing is part of the UEFI spec, we probably should stick it
> there...

I've certainly no problem with moving it under drivers/firmware/efi/,
but please don't create a new subdirectory in drivers/ just for this.

--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/