Re: [PATCH] staging: Merge Crystal HD driver with

From: Steven Newbury
Date: Sun Oct 27 2013 - 13:15:39 EST

On Sun, 2013-10-27 at 09:26 -0700, Greg KH wrote:
> On Sun, Oct 27, 2013 at 05:12:18PM +0000, Steven Newbury wrote:
> > > And these patches do a lot of new work to the driver, I'd rather see it
> > > get fixed up properly and moved out of staging first, before adding new
> > > support to it, otherwise why is it in staging at all?
> >
> > That last part it a good question, it's been sitting there for 3 years,
> > I assume there are specific things that need improving to get it out of
> > staging? Would the changes in this patch, without the support for new
> > hw support be sufficient to get that to happen? I can't test it without
> > that support though...
> See the TODO file for a list of things that need to be resolved.

> - Testing
I can do this for BCM70015 only, hopefully somebody else can test with other

> - Cleanup return codes

> - Cleanup typedefs
For the existing staging driver, this one appears done to me. For the new
code, I notice I've allowed a few to slip back in, I'll fix this.

> - Allocate an Accelerator device class specific Major number,
> since we don't have any other open sourced accelerators, it is the only
> one in that category for now.
> A somewhat similar device is the DXR2/3
Is there a reason this hasn't happened? (staging drivers don't get new major
numbers allocated?) Did nobody actually request a new class, or has there
been no agreement on how to proceed?

> I've been remiss in deleting some of the staging drivers lately, and
> this one was on my shortlist for removal, but if you have hardware for
> it, and want to adopt it, I'll gladly take the patches for getting your
> stuff to work if you are going to work toward getting it out of staging.
I'll get it fixed up, I've an incentive to keep it working to keep my
wife happy! ;-) (It enables the network media box in our bedroom to work
with HD content without the fan screaming!)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at