Re: [git pull] a couple of fixes for rc7

From: Al Viro
Date: Fri Oct 25 2013 - 10:56:49 EST


On Fri, Oct 25, 2013 at 03:33:46PM +0100, Linus Torvalds wrote:
> On Fri, Oct 25, 2013 at 3:25 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> > nfsd performance regression fix + seq_file lseek(2) fix.
> > Please, pull from the usual place -
> > git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus
>
> Not acceptable.
>
> fs/file_table.c: In function ???fput???:
> fs/file_table.c:320:4: warning: passing argument 1 of
> ???schedule_delayed_work??? from incompatible pointer type [enabled by
> default]
> schedule_delayed_work(&delayed_fput_work, 1);
> ^
> In file included from include/linux/srcu.h:34:0,
> from include/linux/notifier.h:15,
> from include/linux/memory_hotplug.h:6,
> from include/linux/mmzone.h:797,
> from include/linux/gfp.h:4,
> from include/linux/slab.h:14,
> from fs/file_table.c:9:
> include/linux/workqueue.h:594:60: note: expected ???struct delayed_work
> *??? but argument is of type ???struct work_struct *???
> static inline bool schedule_delayed_work(struct delayed_work *dwork,
>
> Plase stop sending me untested crap that doesn't even compile cleanly!

Oh, hell... git cherry-pick (for the wrong place, at that) instead of just
pushing the bugger as it was - it sat on top of previous vfs.git#for-linus.
Mea culpa ;-/

I've pushed the right branch now; should propagate in a few minutes.
Head should be at 05e16745c.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/