Re: [git pull] a couple of fixes for rc7

From: Linus Torvalds
Date: Fri Oct 25 2013 - 10:33:52 EST


On Fri, Oct 25, 2013 at 3:25 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> nfsd performance regression fix + seq_file lseek(2) fix.
> Please, pull from the usual place -
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus

Not acceptable.

fs/file_table.c: In function âfputâ:
fs/file_table.c:320:4: warning: passing argument 1 of
âschedule_delayed_workâ from incompatible pointer type [enabled by
default]
schedule_delayed_work(&delayed_fput_work, 1);
^
In file included from include/linux/srcu.h:34:0,
from include/linux/notifier.h:15,
from include/linux/memory_hotplug.h:6,
from include/linux/mmzone.h:797,
from include/linux/gfp.h:4,
from include/linux/slab.h:14,
from fs/file_table.c:9:
include/linux/workqueue.h:594:60: note: expected âstruct delayed_work
*â but argument is of type âstruct work_struct *â
static inline bool schedule_delayed_work(struct delayed_work *dwork,

Plase stop sending me untested crap that doesn't even compile cleanly!

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/