Re: [PATCH next] sysfs: fix sysfs_write_file for bin file

From: Tejun Heo
Date: Thu Oct 24 2013 - 06:31:49 EST


On Wed, Oct 23, 2013 at 09:44:53PM +0800, Ming Lei wrote:
> Before patch(sysfs: prepare path write for unified regular / bin
> file handling), when size of bin file is zero, writting still can
> continue, but this patch changes the behaviour.
>
> The worse thing is that firmware loader is broken by this patch,
> and user space application can't write to firmware bin file any more
> because both firmware loader and drivers can't know at advance how
> large the firmware file is and have to set its initialized size as
> zero.
>
> This patch fixes the problem and keeps behaviour of writting to bin
> as before.
>
> Reported-and-tested-by: Lothar Waßmann <LW@xxxxxxxxxxxxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Signed-off-by: Ming Lei <ming.lei@xxxxxxxxxxxxx>

Oops, sorry about missing that.

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks!

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/