Re: [PATCH v2] Input: add regulator haptic driver

From: Oliver Neukum
Date: Thu Oct 24 2013 - 06:30:19 EST

On Thu, 2013-10-24 at 18:26 +0900, wrote:
> Hi,
> Thanks for your review.
> I resent patch v3 after removing wrong wrapping.
> I made one toggle function because enable/disable functions have redundant codes and another reviewer suggested it.
> Is it better to separate it into two functions?

Linus doesn't like parameters affecting behavior.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at