Re: [PATCH 2/8] ACPI, CPER: Update cper info

[Chen Gong]

On Tue, Oct 15, 2013 at 11:47:23PM +0530, Naveen N. Rao wrote:
> Date: Tue, 15 Oct 2013 23:47:23 +0530
> From: "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx>
> To: "Chen, Gong" <gong.chen@xxxxxxxxxxxxxxx>
> Cc: tony.luck@xxxxxxxxx, bp@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx,
>  linux-acpi@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/8] ACPI, CPER: Update cper info
> User-Agent: Mutt/1.5.21 (2010-09-15)
> 
> On 2013/10/11 02:32AM, Chen Gong wrote:
> > To satisfy the necessary of following patches and make related definition
> > more clear, update some definitions about CPER. No functional changes.
> > 
> > Signed-off-by: Chen, Gong <gong.chen@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/acpi/apei/apei-internal.h | 12 ++++-----
> >  drivers/acpi/apei/cper.c          | 46 ++++++++++++++++-----------------
> >  drivers/acpi/apei/ghes.c          | 54 +++++++++++++++++++--------------------
> >  include/acpi/actbl1.h             | 14 +++++-----
> >  include/acpi/ghes.h               |  2 +-
> >  5 files changed, 64 insertions(+), 64 deletions(-)
> > 
> > diff --git a/drivers/acpi/apei/apei-internal.h b/drivers/acpi/apei/apei-internal.h
> > index f220d64..21ba34a 100644
> > --- a/drivers/acpi/apei/apei-internal.h
> > +++ b/drivers/acpi/apei/apei-internal.h
> > @@ -122,11 +122,11 @@ struct dentry;
> >  struct dentry *apei_get_debugfs_dir(void);
> >  
> >  #define apei_estatus_for_each_section(estatus, section)			\
> > -	for (section = (struct acpi_hest_generic_data *)(estatus + 1);	\
> > +	for (section = (struct acpi_generic_data *)(estatus + 1);	\
> 
> This is a good one to rename, though I wonder if acpi_generic_error_data
> is more appropriate?
> 
> >  	     (void *)section - (void *)estatus < estatus->data_length;	\
> >  	     section = (void *)(section+1) + section->error_data_length)
> >  
> > -static inline u32 apei_estatus_len(struct acpi_hest_generic_status *estatus)
> > +static inline u32 cper_estatus_len(struct acpi_generic_status *estatus)
> 
> Not sure I understand the rationale for these changes - we are still
> dealing with ACPI/APEI generic error status/data structures. So, why
> the cper_ prefix?
> 

Because CPER is not APEI specific, beside APEI, some others like eMCA
needs this.

> >  {
> >  	if (estatus->raw_data_length)
> >  		return estatus->raw_data_offset + \
> > @@ -135,10 +135,10 @@ static inline u32 apei_estatus_len(struct acpi_hest_generic_status *estatus)
> >  		return sizeof(*estatus) + estatus->data_length;
> >  }
> >  
> > -void apei_estatus_print(const char *pfx,
> > -			const struct acpi_hest_generic_status *estatus);
> > -int apei_estatus_check_header(const struct acpi_hest_generic_status *estatus);
> > -int apei_estatus_check(const struct acpi_hest_generic_status *estatus);
> > +void cper_estatus_print(const char *pfx,
> > +			const struct acpi_generic_status *estatus);
> > +int cper_estatus_check_header(const struct acpi_generic_status *estatus);
> > +int cper_estatus_check(const struct acpi_generic_status *estatus);
> 
> Same here. All the above functions work on ACPI structures...
> 
> >  /* Values for block_status flags above */
> >  
> > -#define ACPI_HEST_UNCORRECTABLE             (1)
> > -#define ACPI_HEST_CORRECTABLE               (1<<1)
> > -#define ACPI_HEST_MULTIPLE_UNCORRECTABLE    (1<<2)
> > -#define ACPI_HEST_MULTIPLE_CORRECTABLE      (1<<3)
> > -#define ACPI_HEST_ERROR_ENTRY_COUNT         (0xFF<<4)	/* 8 bits, error count */
> > +#define ACPI_GEN_ERR_UC			(1)
> > +#define ACPI_GEN_ERR_CE			(1<<1)
> > +#define ACPI_GEN_ERR_MULTI_UC		(1<<2)
> > +#define ACPI_GEN_ERR_MULTI_CE		(1<<3)
> > +#define ACPI_GEN_ERR_COUNT_SHIFT	(0xFF<<4) /* 8 bits, error count */
> 
> I'd prefer ACPI_GENERIC_ERR_ since ACPI_GEN_ERR sounds far too much like
> ACPI "Generated" :)
> 
> 
> Thanks,
> Naveen
>

Attachment: signature.asc
Description: Digital signature