Re: [PATCH v10 11/12] tracing: fix tracing_snapshot kerneldoc

From: Tom Zanussi
Date: Fri Oct 11 2013 - 09:29:50 EST


On Fri, 2013-10-11 at 21:50 +0900, Masami Hiramatsu wrote:
> (2013/10/11 9:48), Tom Zanussi wrote:
> > The names of the functions are tracing_snapshot_*, not
> > trace_snapshot_* - fix up the kerneldoc to avoid confusion.
> >
> > Signed-off-by: Tom Zanussi <tom.zanussi@xxxxxxxxxxxxxxx>
>
> It seems that this is not related this series.
> Please send it as a trivial fix patch :)
>

Yeah, I keep adding patches as I test things, and 4 of the patches in
this patchset now fit that description..

Tom

> Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
>
> > ---
> > kernel/trace/trace.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 5aa8f80..81d95bf 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -514,7 +514,7 @@ EXPORT_SYMBOL_GPL(__trace_bputs);
> >
> > #ifdef CONFIG_TRACER_SNAPSHOT
> > /**
> > - * trace_snapshot - take a snapshot of the current buffer.
> > + * tracing_snapshot - take a snapshot of the current buffer.
> > *
> > * This causes a swap between the snapshot buffer and the current live
> > * tracing buffer. You can use this to take snapshots of the live
> > @@ -617,9 +617,9 @@ int tracing_alloc_snapshot(void)
> > EXPORT_SYMBOL_GPL(tracing_alloc_snapshot);
> >
> > /**
> > - * trace_snapshot_alloc - allocate and take a snapshot of the current buffer.
> > + * tracing_snapshot_alloc - allocate and take a snapshot of the current buffer.
> > *
> > - * This is similar to trace_snapshot(), but it will allocate the
> > + * This is similar to tracing_snapshot(), but it will allocate the
> > * snapshot buffer if it isn't already allocated. Use this only
> > * where it is safe to sleep, as the allocation may sleep.
> > *
> >
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/