Re: [PATCH] perf session: Fix infinite loop on invalid perf.data file

From: Arnaldo Carvalho de Melo
Date: Fri Oct 04 2013 - 11:25:36 EST


Em Tue, Oct 01, 2013 at 10:59:06AM -0600, David Ahern escreveu:
> On 10/1/13 10:54 AM, Arnaldo Carvalho de Melo wrote:
> >Em Tue, Oct 01, 2013 at 05:33:09PM +0200, Ingo Molnar escreveu:
> >>* David Ahern <dsahern@xxxxxxxxx> wrote:
> >>>On 10/1/13 8:21 AM, Ingo Molnar wrote:
> >I liked this last one:
> >
> >> WARNING: The perf.data file's data size field is 0 which is unexpected.
> >> Was the 'perf record' command properly terminated?
> >
> >Can I patch that up into Namhyung's latest patch?
> >
> >Sonny, David, from your replies I think I can add Tested-by: tags for
> >both of you?
>
> I'm fine with the last message. And yes a Tested by

Got to process this now, changing it a bit to replace "perf.data" with
"%s" + session->filename, ack?

Otherwise the user may have a 'perf.data' file and despite having
informed -i with a different file name still get confused... ;-)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/