Re: [PATCH] perf session: Fix infinite loop on invalid perf.datafile

[David Ahern]

On 10/1/13 10:54 AM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Oct 01, 2013 at 05:33:09PM +0200, Ingo Molnar escreveu:
> > * David Ahern <dsahern@xxxxxxxxx> wrote:
> >
> > > On 10/1/13 8:21 AM, Ingo Molnar wrote:
> > > > But if I understood it correctly this particular message could trigger for
> > > > regular users of perf as well, of the perf record is terminated in some
> > > > unusual fashion. Regular users might not have the perf code handy (and
> > > > might not know about git grep either).
> > >
> > > This is the case I was referring to -- normal users don't care about
> > > the code reference, hence the more specific question about how the
> > > perf-record session ended.
> >
> > Hm, what do you call 'code reference'?
> >
> > The message I suggested is:
> >
> >    WARNING: perf/header: Data size is 0. Was the 'perf record' command properly terminated?
> >
> > I didn't intend 'perf/header' to be a code reference - it wanted to refer
> > to the perf.data header. Maybe that should be formulated in a less
> > confusing manner? Something like:
>
> I liked this last one:
>
> >    WARNING: The perf.data file's data size field is 0 which is unexpected.
> >             Was the 'perf record' command properly terminated?
>
> Can I patch that up into Namhyung's latest patch?
>
> Sonny, David, from your replies I think I can add Tested-by: tags for
> both of you?

I'm fine with the last message. And yes a Tested by

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/