Re: [PATCH v2] ADP1653 board code for Nokia RX-51

From: Tony Lindgren
Date: Mon Sep 23 2013 - 13:21:56 EST


* Pavel Machek <pavel@xxxxxx> [130921 05:45]:
> Hi!
>
> > > > > > > --- /dev/null
> > > > > > > +++ b/arch/arm/mach-omap2/board-rx51-camera.c
> > > > >
> > > > > [...]
> > > > >
> > > > > > Ping, can you review this patch v2?
> > > > >
> > > > > I don't think Tony will accept any new board stuff for
> > > > > RX-51/N900. See for example:
> > > > > http://marc.info/?l=linux-kernel&m=137629626213187&w=2
> > > > >
> > > > > There should be initial Nokia N900 DTS file in 3.12-rc1, and
> > > > > we should continue converting this board fully to DT.
> > > >
> > > > That's not reasonable. N900 is pretty far away from working
> > > > with device tree. Yes, I was able to get some bits merged,
> > > > but that should not be excuse to halt other N900 development.
> > > > Pavel
> > >
> > > Right. So Tony, will you accept future patches for board files?
> >
> > Only fixes to board-*.c files please unless there's a _really_
> > good reason to make things more complex with the platform data.
> > Let's not make the DT conversion any more complex than it
> > already is.
> >
> > Getting things working with DT for the devices is pretty trivial
> > in most cases. And we can also still initialize the legacy devices
> > using platform data the same way as earlier.
>
> Well... It was quite a struggle to get video working with device tree
> in 3.10, and now it is broken in 3.12-rc1, again.

Hmm didn't Aaro reply that you just need to change the Kconfig
option for the panel to fix it?

> "Now, here, you see, it takes all the running you can do, to keep in
> the same place. If you want to get somewhere else, you must run at
> least twice as fast as that! "

True at least for reading the mailing lists :)

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/