Re: [PATCH] spi: s3c64xx: Add missing compatibles

[Tomasz Figa]

--nextPart5657219.y94VlvC6mD
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"

Hi Mark,

On Monday 23 of September 2013 14:50:42 Mark Brown wrote:
> On Mon, Sep 23, 2013 at 11:45:45AM +0200, Mateusz Krawczuk wrote:
> > Add compatibles for s3c6410, s5pc100 and s5pc110/s5pv210 boards.
> 
> >  static const struct of_device_id s3c64xx_spi_dt_match[] = {
> > +	{ .compatible = "samsung,s3c2443-spi",
> > +			.data = (void *)&s3c2443_spi_port_config,
> > +	},
> > +	{ .compatible = "samsung,s3c6410-spi",
> > +			.data = (void *)&s3c6410_spi_port_config,
> > +	},
> 
> This is missing s3c6400 and at least one other s3c24xx I think.  They
> can be added later though so applied, thanks.

I think after this patch the table lists all the SoC variants supported
by the driver, at least it's what I can tell from a quick look at
s3c64xx_spi_driver_ids[] array.

The compatible for S3C64xx should be probably called "samsung,s3c6400",
though, as it's the first SoC with this variant.

Best regards,
Tomasz

--nextPart5657219.y94VlvC6mD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (GNU/Linux)

iQIcBAABAgAGBQJSQEpIAAoJEIv3Hb8G/XrulM4P/1FIUNOQh25SYRWzfAcdTsCc
qxPWnRKb4TQ+sYBHSGi7YGadLgOgGmDILdQFzDzOB1ANEmqvKCD/xhYSzNKYSjju
hQTM/biX5i/qqdaZ6pedrXlnE+QBBcVvPJ5Wq5aGtJNAtegHyARvVDQU/rQK0Ake
wbqsd5QJbQHgvVtoKKeY/GFqYk9aLOzWUpHkbwg2gzy2Pb4gPqk4HJGRwH8xoEdY
1t6qR7gKDiCgnjO1I4QTTZjuCwE+l5aWhXq49aSo/T+BryEF7qDaY3As31m86QI4
m06SnXiaUvem7H/hpIw9v4STy7Vy9IqQvFY5kSkmRGvXsoIw+0aDmhA4azpohAKn
buccNWXlhkIK8p21O3RwykIUGcE2hCioMkpKvvrytOSQEwKqOA5E0FO1u8/AV5RG
vIOOjLkAAnasdlspC3WiWcVfNsTzon8U226Xbs9zV/fyFK7Byq8H0g+/29BWzVs9
3oVyxMNyVUnB99EUIQV3cG4xqERgOGeMdEhAzYfzPTCB1mhzBJX+yVUB+6IpLnbL
9tLmaXFNLWDS67BpIYcJrbMl8kJ867DIFgJ69xg95RLGgfAbZxFg7G+okwKFrld6
pbPOJjeYSMYmVDOINgrAQ48DgTm1A6NRpfoHvIaKEdEbRYTwtMlDmLebPe5oysoB
Z9ND2tR5pebkaDBufjl0
=taVC
-----END PGP SIGNATURE-----

--nextPart5657219.y94VlvC6mD--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/