Re: [PATCH 4/4] perf tools: Make kmem work for non numa machines

From: Jiri Olsa
Date: Mon Sep 23 2013 - 09:50:51 EST


On Thu, Sep 12, 2013 at 06:39:36PM +0200, Jiri Olsa wrote:
> The commit '2814eb0 perf kmem: Remove die() calls' disabled
> kmem command for machines without numa support. It made the
> command fail if '/sys/devices/system/node' dir wasn't found.
>
> Skipping the numa based initialization in case the directory
> is not found and continue execution.
>
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Corey Ashford <cjashfor@xxxxxxxxxxxxxxxxxx>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Namhyung Kim <namhyung@xxxxxxxxxx>
> Cc: Paul Mackerras <paulus@xxxxxxxxx>
> Cc: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

ping

thanks,
jirka

> ---
> tools/perf/builtin-kmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c
> index c2dff9c..9b5f077 100644
> --- a/tools/perf/builtin-kmem.c
> +++ b/tools/perf/builtin-kmem.c
> @@ -101,7 +101,7 @@ static int setup_cpunode_map(void)
>
> dir1 = opendir(PATH_SYS_NODE);
> if (!dir1)
> - return -1;
> + return 0;
>
> while ((dent1 = readdir(dir1)) != NULL) {
> if (dent1->d_type != DT_DIR ||
> --
> 1.7.11.7
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/