Re: [PATCH 11/26] ARM: dove: remove custom .init_time hook

From: Jason Cooper
Date: Mon Sep 23 2013 - 09:32:32 EST


On Mon, Sep 23, 2013 at 11:10:36AM +0200, Andrew Lunn wrote:
> On Sun, Sep 22, 2013 at 02:20:28PM +0200, Sebastian Hesselbarth wrote:
> > On 09/21/2013 02:22 PM, Andrew Lunn wrote:
> > >On Wed, Sep 18, 2013 at 07:53:44PM +0200, Sebastian Hesselbarth wrote:
> > >>With arch/arm calling of_clk_init(NULL) from time_init(), we can now
> > >>remove custom .init_time hooks. While at it, also remove some obsolete
> > >>includes.
> > >>
> > >>Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx>
> > >>---
> > >>Cc: Olof Johansson <olof@xxxxxxxxx>
> > >>Cc: Arnd Bergmann <arnd@xxxxxxxx>
> > >>Cc: Jason Cooper <jason@xxxxxxxxxxxxxx>
> > >>Cc: Andrew Lunn <andrew@xxxxxxx>
> > >>Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> > >>Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > >>Cc: linux-kernel@xxxxxxxxxxxxxxx
> > >>---
> > >> arch/arm/mach-dove/board-dt.c | 11 -----------
> > >> 1 file changed, 11 deletions(-)
> > [...]
> > >Boot tested on cubox.
> > >
> > >Tested-by: Andrew Lunn <andrew@xxxxxxx>
> >
> > Thanks Andrew!
> >
> > Aren't you giving any Acks for dove/kirkwood anymore?
>
> Hi Sebastian
>
> In my opinion, a Tested-by: has more weight than an Acked-by. I could
> of given you an Acked-by in about 60 seconds, given the simplicity of
> the patch. It took a lot more effort to get your tree, build it, fix
> my binutils, since it was the first 3.12 tree i had tried and my
> binutils was too old, and boot it.

I would even go so far as to say that a Tested-by: from a maintainer
carries an implied Ack. ;-)

And, just for the record,

Acked-by: Jason Cooper <jason@xxxxxxxxxxxxxx>

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/