Re: [PATCH] pinctrl: pinctrl-adi2: Remove nested lock+irqsave thatresue flags.

[Dan Carpenter]

On Mon, Sep 23, 2013 at 05:29:48PM +0800, Sonic Zhang wrote:
> @@ -323,12 +323,12 @@ static unsigned int adi_gpio_irq_startup(struct irq_data *d)
>  	struct gpio_pint_regs *regs = port->pint->regs;
                                      ^^^^^^^^^^^^^^^^
Dereference.

>  
>  	if (!port) {
            ^^^^^
Too late to check here.

> -		dev_err(port->dev, "GPIO IRQ %d :Not exist\n", d->irq);
> +		pr_err("GPIO IRQ %d :Not exist\n", d->irq);
>  		return -ENODEV;
>  	}

regards,
dan carpenter
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/