Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile

[Namhyung Kim]

Hi Jiri,

On Sat, 21 Sep 2013 14:47:14 +0200, Jiri Olsa wrote:
> On Mon, Sep 16, 2013 at 11:11:16AM +0900, Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@xxxxxxx>
>> 
>> Some files need additional compiler flags to be built successfully.
>> Cleanup Makefile by using optional per-file CFLAGS which look like
>> CFLAGS_dir_filename.o
>
> I like it, but I'm getting following error:
>
>   $ make 
>       ...
>       AR libperf.a
>   ar: util/rbtree.o: No such file or directory
>   make: *** [libperf.a] Error 1
>   $
>
> probably because rbtree object is based in kernel lib
>
>
> Also this patch collides with your previous:
>   perf tools: Separate out GTK codes to libperf-gtk.so
>
> which I needed to revert first to get this one applied.

Thanks for the feedback.  I'll take a look and fix them.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/