Re: [RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY

From: Sergei Shtylyov
Date: Sun Sep 22 2013 - 14:24:47 EST


Hello.

On 09/22/2013 08:58 PM, Tejun Heo wrote:

From: Balaji T K <balajitk@xxxxxx>

Some platforms have a PHY hooked up to the
SATA controller. The PHY needs to be initialized
and powered up for SATA to work. We do that
using the PHY framework.

[Roger Q] Cleaned up.

CC: Tejun Heo <tj@xxxxxxxxxx>
Signed-off-by: Balaji T K <balajitk@xxxxxx>
Signed-off-by: Roger Quadros <rogerq@xxxxxx>

Looks okay to me although I don't know whether everyone using
ahci_platform would be happy with requiring phy. Sergei, does this
look good to you?

Not sure why you asked -- I'm not using this driver, neither I'm the author of it (former MV's Anton Vorontsov is IIRC). I've commented on the patch anyway though...

Thanks.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/