Re: [PATCH 46/50] sched: numa: Prevent parallel updates to groupstats during placement

From: Peter Zijlstra
Date: Fri Sep 20 2013 - 08:37:26 EST


On Fri, Sep 20, 2013 at 01:31:52PM +0100, Mel Gorman wrote:
> static inline unsigned long group_weight(struct task_struct *p, int nid)
> {
> + if (!p->numa_group || !p->numa_group->total_faults)
> return 0;
>
> + return 1200 * group_faults(p, nid) / p->numa_group->total_faults;
> }

Unrelated to this change; I recently thought we might want to change
these weight factors based on if the task was predominantly private or
shared.

For shared we use the bigger weight for group, for private we use the
bigger weight for task.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/