Re: [dtc PATCH] Ensure all tests have matching reg and unit address

From: David Gibson
Date: Thu Sep 19 2013 - 18:57:40 EST


On Thu, Sep 19, 2013 at 11:49:41AM -0600, Stephen Warren wrote:
> On 09/19/2013 06:18 AM, David Gibson wrote:
> > On Wed, Sep 18, 2013 at 02:23:02PM -0600, Stephen Warren wrote:
> >> From: Stephen Warren <swarren@xxxxxxxxxx>
> >>
> >> ePAPR 1.1 section 2.2.1.1 "Node Name Requirements" specifies that
> >> any node that has a reg property must include a unit address in
> >> its name with value matching the first entry in its reg property.
> >> Conversely, if a node does not have a reg property, the node name
> >> must not include a unit address.
> >>
> >> Adjust all the dtc test-cases to conform to this rule.
> >>
> >> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>
> >
> > Yeah, the testcase examples were built as purely syntactic
> > exercises without really considering dt content conventions.
> > Fixing them up is arguably unnnecessary, but certainly doesn't hurt
> > and makes them better as examples.
> >
> > Applied and pushed.
>
> Strange; I see that the git author field ended up as you rather than
> me. Did you need to apply the patch manually for some reason (if so,
> what did I do wrong?) or did something go wrong in the patch
> application process?

Oh, dammit. git citool did that when I added my S-o-b, and I forgot
to fix it up. I just patched it up and did a push -f, I hope not too
many people have pulled in the meantime :(.

--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: pgp00000.pgp
Description: PGP signature