Re: [PATCH] ASoC: rt5640: Omit ACPI match table only if !ACPI

From: Mark Brown
Date: Thu Sep 19 2013 - 09:22:56 EST


On Thu, Sep 19, 2013 at 01:21:04PM +0200, Thierry Reding wrote:

> Or perhaps we can annotate the table so that the compiler will stop
> complaining but remove the table nonetheless if it isn't used. Similarly
> to what we can do with
>
> if (IS_ENABLED(CONFIG_FOO)) {
> ...
> }
>
> constructs. I can't really think of a way to do that, though. Perhaps
> gcc will throw away the table anyway, so we'll just need a way to make
> it shut up?

There's an annotation which can stop the unreferenced variable warning
and then modern compilers are able to eliminate unreferenced static
symbols. Not sure if it's actually worth the effort of doing all this
though, but it is nice to be able to avoid needing multiple builds.

Attachment: signature.asc
Description: Digital signature