Re: Fix style in s3c-hsotg.c

[Felipe Balbi]

On Wed, Sep 18, 2013 at 12:04:27AM +0200, Pavel Machek wrote:
> On Tue 2013-09-17 10:42:30, Felipe Balbi wrote:
> > Hi,
> > 
> > On Mon, Sep 02, 2013 at 03:58:32PM +0200, Pavel Machek wrote:
> > > Hi!
> > > 
> > > checkpatch.pl has some valid complaints about style in s3c-hsotg.c :
> > > macro with if should be really enclosed in do {} while, and puts is
> > > going to be slightly faster.
> > > 
> > > Here's suggested patch. I don't have the hardware, so it is completely
> > > untested.
> > > 
> > > Signed-off-by: Pavel Machek, <pavel@xxxxxxx>
> > 
> > this is not how you send a patch, please read
> > Documentation/SubmittingPatches
> 
> Have you considered possibility that this is how you nudge maintainer
> into fix their coding style?

cute...

Seriously though, read that file, you're commit log has garbage in it
which shouldn't go to git history.

-- 
balbi

Attachment: signature.asc
Description: Digital signature