Re: [PATCH v4 1/2] ARM: OMAP: Add secure function omap_smc3()which calling instruction smc #1

From: Tony Lindgren
Date: Tue Sep 17 2013 - 19:18:28 EST


* Pali RohÃr <pali.rohar@xxxxxxxxx> [130917 09:01]:
> On Tuesday 17 September 2013 17:43:31 Tony Lindgren wrote:
> > Have you guys checked how this works with the recently posted
> > "[PATCH v6 0/5] ARM: support for Trusted Foundations secure
> > monitor" series?
>
> this code looks like some Tegra and "Trusted Foundations"
> specific. There is Note: The API followed by Trusted Foundations
> does *not* follow the SMC calling conventions. Also code calling
> smc #0 instruction, so in my opinion for rx51 it is useless.

OK, so still no generic SMC code then :( This patch is fine
with me.

> Tony, can you include this two rx51 secure patches (patch v4 1/2
> and patch v2 2/2)? Or is there some any other problem?

No other comments on this patch, I'll post some comments on the
v2 2/2 patch considering we're moving to device tree based
booting.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/