Re: [patch 5/6] sparc: Use preempt_schedule_irq

From: David Miller
Date: Tue Sep 17 2013 - 18:54:40 EST


From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Date: Tue, 17 Sep 2013 18:53:08 -0000

> bne,pn %xcc, kern_fpucheck
> - sethi %hi(PREEMPT_ACTIVE), %l6
> - stw %l6, [%g6 + TI_PRE_COUNT]
> - call schedule
> + call preempt_schedule_irq
> nop

You've put the function call into the delay slot of the branch,
which you don't want to do.

That's, btw, why we indent instructions with an extra space like
that, to emphasize that it's a delay slot of the preceeding
branch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/