Re: [PATCH V3] regulator: core: add support for configuring turn-ontime through constraints

[Stephen Warren]

On 09/17/2013 05:45 AM, Laxman Dewangan wrote:
> The Turn-on time of the regulator depends on the regulator device's
> electrical characteristics. Sometimes regulator turn-on time also
> depends on the capacitive load on the given platform and it can be
> more than the datasheet value.
> 
> The driver provides the enable-time as per datasheet.
> 
> Add support for configure the enable ramp time through regulator
> constraints so that regulator core can take this value for enable
> time for that regulator.

> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt

> +- regulator-enable-ramp-delay: Turn-on time for regulator(in microsecond).

You need a space before (. You don't even need the brackets.
microseconds not microsecond.

> +  This is the time time taken to reach the target voltage from off state.
> +  The delay specified in the DT to just completely override what the drivers
> +  know.

This description references driver behaviour which it really shouldn't.
Instead, it should describe the HW itself. How about the following text,
which I suggested last time:

- regulator-enable-ramp-delay: The time taken, in microseconds, for the
supply rail to reach the target voltage, plus/minus whatever tolerance
the board design requires. This property describes the total system ramp
time required due to the combination of internal ramping of the
regulator itself, and board design issues such as trace capacitance and
load on the supply.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/