Re: [PATCH] adjust the error labels to make it clear

[Greg KH]

On Tue, Sep 17, 2013 at 05:15:13PM +0800, baisong zhong wrote:
> From: zhongbaisong <baisong.zhong@xxxxxxxxx>
> 
> Signed-off-by: zhongbaisong <baisong.zhong@xxxxxxxxx>

I need a changelog description in here, as to why you are making this
change, your Subject: is not descriptive at all.  What is being made
"clear"?

> ---
>  fs/sysfs/mount.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c
> index afd8327..f6681a6 100644
> --- a/fs/sysfs/mount.c
> +++ b/fs/sysfs/mount.c
> @@ -182,12 +182,12 @@ int __init sysfs_init(void)
>  		}
>  	} else
>  		goto out_err;
> -out:
> -	return err;
> +
>  out_err:
>  	kmem_cache_destroy(sysfs_dir_cachep);
>  	sysfs_dir_cachep = NULL;
> -	goto out;
> +out:
> +	return err;

You tested this patch right?  Are you sure?  Really really sure?

greg "I don't think you tested this" k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/