Re: [PATCH v2 15/24] Staging: winbond: reg: seventh of the patchesthat fixes lines over 80 characters

[Dan Carpenter]

On Tue, Sep 17, 2013 at 02:29:22PM +0530, Adil Mujeeb wrote:
> Hi,
> 
> 
> >-       PowerData = (1 << 31) | (0 << 30) | (24 << 24) |
> BitReverse(w89rf242_txvga_data[i][0], 24);
> >+       PowerData = (1 << 31) | (0 << 30) | (24 << 24)
> >+                           | BitReverse(w89rf242_txvga_data[i][0], 24);
> .....
> .....
> 
> >-       reg->M38_MacControl = (DEFAULT_RATE_RETRY_LIMIT << 8) |
> (DEFAULT_LONG_RETRY_LIMIT << 4) | DEFAULT_SHORT_RETRY_LIMIT;
> >+       reg->M38_MacControl = (DEFAULT_RATE_RETRY_LIMIT << 8) |
> >+                                      (DEFAULT_LONG_RETRY_LIMIT << 4) |
> >+                                      DEFAULT_SHORT_RETRY_LIMIT;
> 
> I think consistency is needed. Either break the lines putting the OR
> operator ( | ) at the start of new line or at the end of each line. People
> has its own preference but here you have used both style in single file.
> Just a suggestion.
> 

Put the '|' character at the end of the line.  That's the New Unwritten
Style Guidelines.  Most of the kernel does it this way and it's easier
to read.

But this could be fixed in a later patch instead of redoing the whole
series.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/