Re: [PATCH] Time: Clocksource: fix 'ret' data type of sysfs_override_clocksource()and sysfs_unbind_clocksource()

[John Stultz]

On 09/12/2013 03:28 AM, elad.wexler@xxxxxxxxx wrote:
> From: Elad Wexler <elad.wexler@xxxxxxxxx>
>
> sysfs_override_clocksource(): The expression 'if (ret >= 0)' is always true.
> This will cause clocksource_select() to always run.
> Thus modified ret to be of type ssize_t.
>
> sysfs_unbind_clocksource(): The expression 'if (ret < 0)' is always false.
> So in case sysfs_get_uname() failed, the expression won't take an effect.
> Thus modified ret to be of type ssize_t.
>
> Signed-off-by: Elad Wexler <elad.wexler@xxxxxxxxx>

Queued for 3.13.

thanks
-john

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/