[PATCH 07/11] gfs2: pass correct dentry to finish_open() in __gfs2_lookup()

From: Miklos Szeredi
Date: Mon Sep 16 2013 - 08:53:12 EST


From: Miklos Szeredi <mszeredi@xxxxxxx>

AFAICS if d_splice_alias() returned non-NULL, this code would Oops
(finish_open expects an instantiated dentry).

Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx>
Cc: Steven Whitehouse <swhiteho@xxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
---
fs/gfs2/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 6d7f976..abe7dae 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -774,7 +774,7 @@ static struct dentry *__gfs2_lookup(struct inode *dir, struct dentry *dentry,

d = d_splice_alias(inode, dentry);
if (file && S_ISREG(inode->i_mode))
- error = finish_open(file, dentry, gfs2_open_common, opened);
+ error = finish_open(file, d ? d : dentry, gfs2_open_common, opened);

gfs2_glock_dq_uninit(&gh);
if (error)
--
1.8.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/