Re: perf/compat: Sharpen the libaudit dependencies test

From: Arnaldo Carvalho de Melo
Date: Fri Sep 13 2013 - 15:21:05 EST


Em Thu, Sep 12, 2013 at 03:27:06PM +0200, Ingo Molnar escreveu:
> There are older libaudit versions that don't have an audit_errno_to_name()
> method, resulting in a builtin-trace.c build error:
>
> builtin-trace.c: In function âtrace__sys_exitâ:
> builtin-trace.c:794: warning: implicit declaration of function âaudit_errno_to_nameâ
>
> Expand the libaudit test to detect this.

Lets sharpen it a bit more ;-)

CHK libaudit
<stdin>: In function âmainâ:
<stdin>:5:9: error: âerrorâ undeclared (first use in this function)
<stdin>:5:9: note: each undeclared identifier is reported only once for each function it appears in
<stdin>:5:15: error: expected â)â before âmessageâ
make: Entering directory `/home/git/linux/tools/perf'
config/Makefile:238: No libaudit.h found, disables 'trace' tool, please install audit-libs-devel or libaudit-dev

We need this folded in to buind it, so that the test works:

diff --git a/tools/perf/config/feature-tests.mak b/tools/perf/config/feature-tests.mak
index 5608add..7f550c1 100644
--- a/tools/perf/config/feature-tests.mak
+++ b/tools/perf/config/feature-tests.mak
@@ -210,7 +210,7 @@ define SOURCE_LIBAUDIT

int main(void)
{
- printf("error message: %s\n", audit_errno_to_name(0));
+ printf(\"error message: %s\n\", audit_errno_to_name(0));
return audit_open();
}
endef

Applying, thanks!

- Arnaldo

>
> diff --git a/tools/perf/config/feature-tests.mak b/tools/perf/config/feature-tests.mak
> index 708fb8e..5608add 100644
> --- a/tools/perf/config/feature-tests.mak
> +++ b/tools/perf/config/feature-tests.mak
> @@ -210,6 +210,7 @@ define SOURCE_LIBAUDIT
>
> int main(void)
> {
> + printf("error message: %s\n", audit_errno_to_name(0));
> return audit_open();
> }
> endef
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/