Re: [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleepusers

From: Andi Kleen
Date: Wed Sep 11 2013 - 00:51:16 EST


On Tue, Sep 10, 2013 at 04:52:12PM -0700, Andrew Morton wrote:
> On Sat, 31 Aug 2013 20:22:23 +0200 Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> > On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen <andi@xxxxxxxxxxxxxx> wrote:
> > > might_sleep is moving from linux/kernel.h to linux/sched.h, so any users
> > > need to include linux/sched.h
> >
> > Really? <linux/sched.h> is the worst choice w.r.t. include hell.
>
> Yes. Mechanically adding sched.h inclusions into .h files will cause
> problems.
>
> I've had decent success with this sort of thing by adding new,
> finer-grained headers. Maybe include/linux/might_sleep.h would be a
> good starting point to fix whatever it was that this fixed.

Ok. I'll look into that and send new patches.

Some of it may be obsolete with Peter's recent preempt work.

> I think I'll make x86-include-linux-schedh-in-asm-uaccessh.patch,
> tree-sweep-include-linux-schedh-for-might_sleep-users.patch and
> sched-mark-should_resched-__always_inline.patch go away for now - I
> need a mergeable tree, fast.

Fair enough.

-Andi


--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/