Re: [PATCH 1/2] staging: zram: minimize `slot_free_lock' usage (v2)

From: Dan Carpenter
Date: Mon Sep 09 2013 - 10:52:56 EST


On Mon, Sep 09, 2013 at 05:42:59PM +0300, Sergey Senozhatsky wrote:
> > 3) Explain why it is safe to test zram->slot_free_rq when we are not
> > holding the lock. I think it is unsafe. I don't want to even think
> > about it without the numbers.
>
> atomic pointer test, which is either NULL or !NULL.
>

That's not how concurency works. Atomic types are complicated than
that. Anyway, the zram maintainers don't need me to explain that to
them so I'll let them take over from here.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/