Re: [REVIEW][PATCH 1/2] userns: Better restrictions on when proc and sysfs can be mounted

From: Eric W. Biederman
Date: Tue Aug 27 2013 - 17:57:18 EST


Andy Lutomirski <luto@xxxxxxxxxxxxxx> writes:

> On Tue, Aug 27, 2013 at 2:44 PM, Eric W. Biederman
> <ebiederm@xxxxxxxxxxxx> wrote:
>>
>> Rely on the fact that another flavor of the filesystem is already
>> mounted and do not rely on state in the user namespace.
>
> Possibly dumb question: does this check whether the pre-existing mount
> has hidepid set?

Not currently.

It may be worth doing something with respect to hidepid. I forget what
hidepid tries to do, and I need to dash. But feel free to cook up a
follow on patch.

My goal is simply to reduce the hack level and increase the readability
and maintainability of the code.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/