Re: [PATCH] proc: make proc_fd_permission() thread-friendly

[Linus Torvalds]

On Mon, Aug 26, 2013 at 11:09 AM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Patch looks ok to me, but since this has never worked and nobody has
> actually complained, I can't really convince myself that this is
> critical.

Actually, let's back-track..

Did you try the other approach? Make /proc/self point to the thread
instead of the task?

The thread-group leader seems to have these extra files:

 - autogroup, coredump_filter, mountstats, net, task

but quite frankly, at least "net" and "task" look like they should
exist there - with "task" pointing back to the actual task (it would
make more sense for "/proc/<pid>/task" itself to be named "threads",
but whatever).

Yes, it would be semantically different, but it would mean that
"/proc/self/fd/" would actually make sense in a way that it currently
does *not* - which would seem fairly important, since the primary use
for it tends to be /dev/stdin.

And the other semantic differences might be much harder to notice.
Worth testing?

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/