Re: [PATCH] proc: make proc_fd_permission() thread-friendly

From: Linus Torvalds
Date: Mon Aug 26 2013 - 14:09:31 EST


On Mon, Aug 26, 2013 at 10:54 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> proc_fd_permission() says "process can still access /proc/self/fd
> after it has executed a setuid()", but the "task_pid() = proc_pid()
> check only helps if the task is group leader, /proc/self points to
> /proc/leader-pid.

Patch looks ok to me, but since this has never worked and nobody has
actually complained, I can't really convince myself that this is
critical.

So I'm not going to apply it for 3.11, and it had better wait for the
next merge window.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/