Re: [PATCH 3/4] printk: Defer printing to irq work when we printedtoo much

From: Steven Rostedt
Date: Thu Aug 15 2013 - 09:26:55 EST


On Thu, 15 Aug 2013 09:52:51 +0200
Jan Kara <jack@xxxxxxx> wrote:


> > > +/*
> > > + * How much characters can we print in one call of printk before offloading
> > > + * printing work
> > > + */
> > > +#define MAX_PRINTK_CHARS 1000
> >
> > This really needs to be configurable. 1000 may be good for you, but may
> > not be good for others. Heck, we should be able to disable this
> > offloading too.
> >
> > This should probably be added to the printk /proc/sys/kernel/... files.
> >
> > If it is set to zero, then disable any offloading.
> OK, I can easily do this. I'm somewhat skeptical people would want to
> tune this but maybe they would.
>

Most people wouldn't. But as this is a new heuristic, if things are not
behaving as people expect, then it would be good to be able to modify
that heuristic to see if that was the issue. Including, disabling it.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/