Re: Review [2/2] Staging: BCM: Removed more whitespace/Errors

From: Greg KH
Date: Mon Aug 12 2013 - 18:13:27 EST


On Thu, Aug 08, 2013 at 06:35:32PM +0100, Paul McQuade wrote:
> From 9f6231ce16996e35545e20ce1d91abc058f2a6fb Mon Sep 17 00:00:00 2001
> From: Paul McQuade <paulmcquad@xxxxxxxxx>
> Date: Thu, 8 Aug 2013 17:49:22 +0100
> Subject: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors

Why is this duplicated here?

Just use 'git send-email' to send patches out, that way this isn't a
problem, and also:

> drivers/staging/bcm/InterfaceMacros.h | 6 +-
> drivers/staging/bcm/InterfaceMisc.h | 14 +--
> drivers/staging/bcm/InterfaceRx.c | 166
> ++++++++++++++-------------------

Your patch is line-wrapped, making it impossible to apply :(

The whitespace is also all broken.

Take a look at the kernel file, Documentation/email_clients.txt for how
to fix this up properly.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/