Re: [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecatedIRQF_DISABLED

From: Kumar Gaurav
Date: Fri Aug 09 2013 - 16:00:27 EST


On Saturday 10 August 2013 01:08 AM, Sergei Shtylyov wrote:
Hello.

On 08/09/2013 10:25 PM, Kumar Gaurav wrote:

Removed IRQF_DISABLED as it is deprecated and fixed a coding style issue
of more than 80 chars on single line by sliting the line in two.

That's clearly a material for 2 separate patches.

Signed-off-by: Kumar Gaurav <kumargauravgupta3@xxxxxxxxx>
---
drivers/net/ethernet/lantiq_etop.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index bfdb0686..04c3a82 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
[...]
@@ -653,7 +653,9 @@ ltq_etop_init(struct net_device *dev)
if (err)
goto err_netdev;

- /* Set addr_assign_type here, ltq_etop_set_mac_address would reset it. */
+ /* Set addr_assign_type here,
+ *ltq_etop_set_mac_address would reset it.

You forgot space after * here.

WBR, Sergei

Okay i'll be sending them in separate and correcting a space issue as told.
thanks

Regards
Kumar Gaurav
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/