Re: [PATCH v2 3/3] Documentation: dt: hwmon: add OF document forlm90

From: Wei Ni
Date: Fri Aug 09 2013 - 02:10:22 EST


On 08/09/2013 01:37 AM, Stephen Warren wrote:
> On 08/08/2013 12:56 AM, Wei Ni wrote:
>> Add OF document for lm90 in Documentation/devicetree/.
>
>> diff --git a/Documentation/devicetree/bindings/hwmon/lm90.txt b/Documentation/devicetree/bindings/hwmon/lm90.txt
>
>> +Required node properties:
>> +- compatible: manufacture and chip name,
>> + which are listed in the Documentation/hwmon/lm90
>
> You need to specify the exact values here. DT binding documentations
> should be OS-agnostic, and hence can't depend on Linux-specific
> documentation or other details.

Ok, I will list it.

>
>> +Optional properties:
>> +- vdd-supply: vdd regulator for the supply voltage. If this is not set,
>
> s/set/present/.

Oh, yes, I will change it.

>
>> +- interrupts: lm90 can support interrupt mode, you can set interrupt here.
>
> You might want to mention that a single entry ("specifier") is expected
> in the list.

Sorry, I didn't get your point, could you explain more?

>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/