Re: [PATCH 00/11] Add compression support to pstore

From: Tony Luck
Date: Tue Aug 06 2013 - 23:26:01 EST


On Tue, Aug 6, 2013 at 6:58 PM, Aruna Balakrishnaiah
<aruna@xxxxxxxxxxxxxxxxxx> wrote:
> The patch looks right. I will clean it up. Does the issue still persist
> after this?

Things seem to be working - but testing has hardly been extensive (just
a couple of forced panics).

I do have one other question. In this code:

>> if (compressed && (type == PSTORE_TYPE_DMESG)) {
>> big_buf_sz = (psinfo->bufsize * 100) / 45;

Where does the magic multiply by 1.45 come from? Is that always enough
for the decompression of "dmesg" type data to succeed?

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/