Re: [PATCH] ACPI, cpu hotplug: move try_offline_node() after acpi_unmap_lsapic()

From: Yasuaki Ishimatsu
Date: Tue Aug 06 2013 - 23:24:11 EST

(2013/08/07 1:56), Toshi Kani wrote:
On Tue, 2013-08-06 at 19:11 +0900, Yasuaki Ishimatsu wrote:
try_offline_node() checks that all cpus related with removed node have been
removed by using cpu_present_bits. If all cpus related with removed node have
been removed, try_offline_node() clears the node information.

But try_offline_node() called from acpi_processor_remove() never clears
the node information. For disabling cpu_present_bits, acpi_unmap_lsapic()
need be called. But acpi_unmap_lsapic() is called after try_offline_node()
runs. So when try_offline_node() runs, the cpu's cpu_present_bits is always

This patch moves try_offline_node() after acpi_unmap_lsapic().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@xxxxxxxxxxxxxx>

The change looks good to me.

Acked-by: Toshi Kani <toshi.kani@xxxxxx>

Thanks, Toshi!

BTW, do you know why try_offline_node() has to use stop_machine()?

I don't know the reason.

Yasuaki Ishimatsu


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at