Re: [PATCH 1/3] mips/kvm: Improve code formatting inarch/mips/kvm/kvm_locore.S

From: Ralf Baechle
Date: Mon Aug 05 2013 - 09:22:14 EST


On Mon, Aug 05, 2013 at 02:17:01PM +0100, James Hogan wrote:

>
> On 01/08/13 21:22, David Daney wrote:
> > From: David Daney <david.daney@xxxxxxxxxx>
> >
> > No code changes, just reflowing some comments and consistently using
> > tabs and spaces. Object code is verified to be unchanged.
> >
> > Signed-off-by: David Daney <david.daney@xxxxxxxxxx>
> > Acked-by: Ralf Baechle <ralf@xxxxxxxxxxxxxx>
>
>
> > + /* Put the saved pointer to vcpu (s1) back into the DDATA_LO Register */
>
> git am detects a whitespace error here ("space before tab in indent").
> It's got spaces before and after the tab actually.
>
> > /* load the guest context from VCPU and return */
>
> this comment could have it's indentation fixed too
>
> Otherwise, for all 3 patches:
>
> Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx>

I'm happy with the patch series as well and will fix this issue when
applying the patch.

Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/